Bug 132994 – [Mac] naturalSize not updated when preload=metadata

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac] naturalSize not updated when preload=metadata

[Jer Noble]

Created attachment 231582 [details]
Patch

[Jer Noble]

<rdar://problem/16943809>

[Eric Carlson]

Comment on attachment 231582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231582&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1485
> +        if (AVAssetTrack* firstVideoTrack = [videoTracks firstObject])
> +            presentationSizeDidChange(IntSize(CGSizeApplyAffineTransform([firstVideoTrack naturalSize], [firstVideoTrack preferredTransform])));
> +        else
> +            presentationSizeDidChange(IntSize());

This won't be correct if the first video track isn't enabled.

[Jer Noble]

Created attachment 231584 [details]
Patch for landing.

[Jer Noble]

Created attachment 231586 [details]
Patch for landing.

[WebKit Commit Bot]

Attachment 231586 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1459:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 231586 [details]
Patch for landing.

Clearing flags on attachment: 231586

Committed r168979: <http://trac.webkit.org/changeset/168979>

[Ahmad Saleem]

Seems it landed but not got reverted (checked on GitHub with bug ID).

[Radar WebKit Bug Importer]

<rdar://problem/113003827>