Bug 132994 - [Mac] naturalSize not updated when preload=metadata
Summary: [Mac] naturalSize not updated when preload=metadata
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-16 11:48 PDT by Jer Noble
Modified: 2014-06-24 08:44 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.12 KB, patch)
2014-05-16 12:09 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing. (6.87 KB, patch)
2014-05-16 12:39 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing. (5.97 KB, patch)
2014-05-16 12:42 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-05-16 11:48:43 PDT
[Mac] naturalSize not updated when preload=metadata
Comment 1 Jer Noble 2014-05-16 12:09:46 PDT
Created attachment 231582 [details]
Patch
Comment 2 Jer Noble 2014-05-16 12:16:25 PDT
<rdar://problem/16943809>
Comment 3 Eric Carlson 2014-05-16 12:22:59 PDT
Comment on attachment 231582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231582&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1485
> +        if (AVAssetTrack* firstVideoTrack = [videoTracks firstObject])
> +            presentationSizeDidChange(IntSize(CGSizeApplyAffineTransform([firstVideoTrack naturalSize], [firstVideoTrack preferredTransform])));
> +        else
> +            presentationSizeDidChange(IntSize());

This won't be correct if the first video track isn't enabled.
Comment 4 Jer Noble 2014-05-16 12:39:57 PDT
Created attachment 231584 [details]
Patch for landing.
Comment 5 Jer Noble 2014-05-16 12:42:23 PDT
Created attachment 231586 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2014-05-16 12:43:39 PDT
Attachment 231586 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1459:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2014-05-16 14:32:41 PDT
Comment on attachment 231586 [details]
Patch for landing.

Clearing flags on attachment: 231586

Committed r168979: <http://trac.webkit.org/changeset/168979>