Bug 132975 - old-run-webkit-tests: allow specifying a simulator app path
Summary: old-run-webkit-tests: allow specifying a simulator app path
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad All
: P2 Normal
Assignee: David Farler
Depends on:
Reported: 2014-05-15 16:43 PDT by David Farler
Modified: 2014-05-16 09:35 PDT (History)
1 user (show)

See Also:

Patch (1.94 KB, patch)
2014-05-15 17:22 PDT, David Farler
no flags Details | Formatted Diff | Diff
Patch (2.15 KB, patch)
2014-05-16 08:47 PDT, David Farler
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2014-05-15 16:43:20 PDT
Since the iOS simulator app bundle may not already be registered with launch services (multiple relocatable Xcode.app bundles may exist on the machine), provide a command line parameter to specify exactly where the simulator app is for the first launch.
Comment 1 David Farler 2014-05-15 17:22:28 PDT
Created attachment 231544 [details]
Comment 2 David Kilzer (:ddkilzer) 2014-05-15 18:36:58 PDT
Comment on attachment 231544 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=231544&action=review

r=me, but consider providing a more specific default as well based on $SDKROOT.

> Tools/Scripts/old-run-webkit-tests:191
> +my $simulatorApp = 'iOS Simulator';

Instead of specifying a command-line argument, why not just construct the path based on the $SDKROOT path?

It's always installed at a well-known location, so we should be able to construct the path using the $SDKROOT.

I'm surprised there isn't a way to find it using 'xcrun -sdk iphonesimulator', but maybe that's only for command-line executables.
Comment 3 David Farler 2014-05-16 08:46:09 PDT
Roger. I guess it would be better to do something like the following, which should provide an accurate default. I guess most people aren't switching between Xcode.app bundles on an hourly basis :).

chomp(my $developerDir = $ENV{DEVELOPER_DIR} || `xcode-select --print-path`);
my $simulatorApp = "$developerDir/Applications/iOS Simulator.app";
unless (-d $simulatorApp) {
    $simulatorApp = "$developerDir/Applications/iPhone Simulator.app";
Comment 4 David Farler 2014-05-16 08:47:34 PDT
Created attachment 231574 [details]
Comment 5 David Farler 2014-05-16 09:35:08 PDT
Committed r168969: <http://trac.webkit.org/changeset/168969>