RESOLVED FIXED132959
TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac 
https://bugs.webkit.org/show_bug.cgi?id=132959
Summary TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
David Kilzer (:ddkilzer)
Reported 2014-05-15 09:09:40 PDT
Add a Tools/TestWebKitAPI/Tests/cocoa directory and move URLExtras.mm into it. This will make the test runnable on the iOS Simulator once Bug 129535 lands to add iOS support to run-api-tests. There is much more to do in this space, but this is a start.
Attachments
Patch v1 (3.20 KB, patch)
2014-05-15 09:14 PDT, David Kilzer (:ddkilzer) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-05-15 09:14:00 PDT
Created attachment 231522 [details] Patch v1
mitz
Comment 2 2014-05-15 09:20:25 PDT
Comment on attachment 231522 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963 > + 44A82E7B19251B3500C1C8C4 /* cocoa */, I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories.
David Kilzer (:ddkilzer)
Comment 3 2014-05-15 10:09:50 PDT
(In reply to comment #2) > (From update of attachment 231522 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963 > > + 44A82E7B19251B3500C1C8C4 /* cocoa */, > > I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories. Okay, will change to Cocoa. Thanks!
David Kilzer (:ddkilzer)
Comment 4 2014-05-15 10:19:18 PDT
Committed r168900: <http://trac.webkit.org/changeset/168900>
Note You need to log in before you can comment on or make changes to this bug.