Bug 132954 - webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
Summary: webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PA...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Blocks: 132955
  Show dependency treegraph
Reported: 2014-05-15 08:09 PDT by David Kilzer (:ddkilzer)
Modified: 2014-05-19 15:40 PDT (History)
10 users (show)

See Also:

Patch v1 (12.11 KB, patch)
2014-05-15 08:21 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-05-15 08:09:46 PDT
This started out as just adding __XPC_DYLD_FRAMEWORK_PATH to bisect-builds, but then I tried to share more code in webkitdirs.pm by creating a common "environment setup" subroutine, but the extracted code also set up guardmalloc which seemed useful*, and it seemed silly to manually add '-g|--guard-malloc' switch parsing and help text to every script, so I added methods to make it easy to parse and print help for shared switching (initially just -g|--guard-malloc).

In the mid-term, I think we should investigate a WebKit::Options[Parser] class that wraps Getopt::Long, knows about sets of common switches, and knows how to print help by passing it a list of switches for a particular script.

* Already found a bug in WebKit2.CookieManager when run under guardmalloc.  (Not a crash, but test expectation fails.)
Comment 1 David Kilzer (:ddkilzer) 2014-05-15 08:21:58 PDT
Created attachment 231517 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2014-05-15 08:23:56 PDT
(In reply to comment #0)
> * Already found a bug in WebKit2.CookieManager when run under guardmalloc.  (Not a crash, but test expectation fails.)

I filed this as Bug 132955.
Comment 3 WebKit Commit Bot 2014-05-19 02:18:26 PDT
Comment on attachment 231517 [details]
Patch v1

Clearing flags on attachment: 231517

Committed r169042: <http://trac.webkit.org/changeset/169042>
Comment 4 WebKit Commit Bot 2014-05-19 02:18:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 David Kilzer (:ddkilzer) 2014-05-19 15:40:25 PDT
(In reply to comment #5)
> Did this break run-api-tests?
> http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/14033/steps/run-api-tests/logs/stdio

Speculative fix:

Committed r169078: <http://trac.webkit.org/changeset/169078>