Bug 132936 - [EFL][WK2] Use default context for ewk_view_add
Summary: [EFL][WK2] Use default context for ewk_view_add
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-14 20:33 PDT by Ryuan Choi
Modified: 2014-05-14 21:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2014-05-14 20:43 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2014-05-14 20:55 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-05-14 20:33:32 PDT 
It's regression of r146265.
Comment 1 Ryuan Choi 2014-05-14 20:43:25 PDT 
Created attachment 231485 [details]
Patch
Comment 2 Ryuan Choi 2014-05-14 20:55:41 PDT 
Created attachment 231487 [details]
Patch
Comment 3 Jinwoo Song 2014-05-14 21:03:31 PDT 
Comment on attachment 231487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231487&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:254
> +    ASSERT_EQ(ewk_view_context_get(view), ewk_context_default_get());

You have to change the parameter order because ewk_context_default_get() is the expected result in this case.
Comment 4 Ryuan Choi 2014-05-14 21:21:29 PDT 
Committed r168891: <http://trac.webkit.org/changeset/168891>
Comment 5 Ryuan Choi 2014-05-14 21:33:19 PDT 
Comment on attachment 231487 [details]
Patch

thanks, fixed and landed.