WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
132923
[GTK] Layout Test http/tests/security/cross-origin-plugin-private-browsing-toggled.html is failing
https://bugs.webkit.org/show_bug.cgi?id=132923
Summary
[GTK] Layout Test http/tests/security/cross-origin-plugin-private-browsing-to...
Carlos Alberto Lopez Perez
Reported
2014-05-14 14:37:16 PDT
On platform GTK the Layout Test http/tests/security/cross-origin-plugin-private-browsing-toggled.html is failing. This test was removed from the expectations on
http://trac.webkit.org/changeset/159744
However is failing again now. Investigating the specific revision that made it start failing again is pending.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2014-05-14 18:25:40 PDT
(In reply to
comment #0
)
> Investigating the specific revision that made it start failing again is pending.
This is the summary of my investigation for this test on the GTK port (release build). The following timeline was obtained with the help of
https://github.com/clopez/webkit-testhunter
http://trac.webkit.org/changeset/156532
<-- Test stop failing on GTK (msanchez)
http://trac.webkit.org/changeset/159744
<-- Test get removed from GTK TestExpectations (msanchez)
http://trac.webkit.org/changeset/168668
<-- Test starts failing again on GTK (jhoneycutt) Before
r168668
the test only works if you run many tests in parallel (Fails otherwise) For example: Try to build
r168667
and test to run all the http/* tests in parallel with: Tools/Scripts/run-webkit-tests --no-show-results --no-new-test-results --no-sample-on-timeout --results-directory layout-test-results --debug-rwt-logging --release --webkit-test-runner --gtk --retry-failures http You will see that http/tests/security/cross-origin-plugin-private-browsing-toggled.html passes. Now, on
r168667
run only the test http/tests/security/cross-origin-plugin-private-browsing-toggled.html alone: Tools/Scripts/run-webkit-tests --no-show-results --no-new-test-results --no-sample-on-timeout --results-directory layout-test-results --debug-rwt-logging --release --webkit-test-runner --gtk --retry-failures http/tests/security/cross-origin-plugin-private-browsing-toggled.html It will fail!. Now, if you build
r168668
, and try the tests again, you will see that this test fails always. No matter if you run the test alone or in parallel with the other tests. This drove me crazy because I was not able to reproduce the behaviour reported by the bot, until I tried to run all the test suite (like the bot does) instead of only running this test alone. Summarizing: ------------ -> Before
r168668
: The test fails if you run it alone, but works if you run it in parallel with the other tests. -> On
r168668
: The test fails always. So maybe there is some race condition here?
Carlos Alberto Lopez Perez
Comment 2
2014-05-14 19:00:03 PDT
I have updated the TestExpectations file for GTK for this test on
r168865
<
http://trac.webkit.org/r168865
> [.....] And I have just noticed that
r168668
got reverted on 168843 <
http://trac.webkit.org/168843
>
Carlos Garcia Campos
Comment 3
2020-08-17 06:42:06 PDT
Plugins are no longer supported.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug