Bug 132918 - JSDOMWindow should not claim HasImpureGetOwnPropertySlot
Summary: JSDOMWindow should not claim HasImpureGetOwnPropertySlot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 132705
  Show dependency tree / graph
 
Reported: 2014-05-14 11:51 PDT by Mark Hahnenberg
Modified: 2014-05-15 16:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.33 KB, patch)
2014-05-15 15:30 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-05-14 11:51:54 PDT 
We now correctly handle the impurity of JSDOMWindow's custom getOwnPropertySlot without needing the blanket HasImpureGetOwnPropertySlot. Getting rid of this flag will allow us to cache many properties/methods on both the JSDOMWindow and its prototype, which are very commonly used across the web.
Comment 1 Mark Hahnenberg 2014-05-15 15:30:08 PDT 
Created attachment 231536 [details]
Patch
Comment 2 Geoffrey Garen 2014-05-15 15:49:53 PDT 
Comment on attachment 231536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231536&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        We now correctly handle the impurity of JSDOMWindow's custom getOwnPropertySlot without needing the 
> +        blanket HasImpureGetOwnPropertySlot. Getting rid of this flag will allow us to cache many 

Should specify that we do this through explicit watchpoint.
Comment 3 Mark Hahnenberg 2014-05-15 16:03:38 PDT 
Committed r168914: <http://trac.webkit.org/changeset/168914>
Comment 4 Mark Hahnenberg 2014-05-15 16:04:21 PDT 
Comment on attachment 231536 [details]
Patch

Clearing review flag.