Bug 132916 - Inline caching for proxies clobbers baseGPR too early
Summary: Inline caching for proxies clobbers baseGPR too early
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Blocks: 132705
  Show dependency treegraph
Reported: 2014-05-14 11:10 PDT by Mark Hahnenberg
Modified: 2014-05-14 13:49 PDT (History)
2 users (show)

See Also:

Patch (3.31 KB, patch)
2014-05-14 13:01 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-05-14 11:10:49 PDT
It clobbers it prior to the Structure checks, so if any of the checks fail then the slow path gets the target of the proxy rather than the proxy itself. We need to delay the clobbering of baseGPR until we know the inline cache is going to succeed.
Comment 1 Mark Hahnenberg 2014-05-14 13:01:25 PDT
Created attachment 231463 [details]
Comment 2 WebKit Commit Bot 2014-05-14 13:49:28 PDT
Comment on attachment 231463 [details]

Clearing flags on attachment: 231463

Committed r168861: <http://trac.webkit.org/changeset/168861>
Comment 3 WebKit Commit Bot 2014-05-14 13:49:30 PDT
All reviewed patches have been landed.  Closing bug.