Bug 132912 - Implement NSSharingServiceDelegate method "transitionImageForShareItem"
Summary: Implement NSSharingServiceDelegate method "transitionImageForShareItem"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-14 09:50 PDT by Brady Eidson
Modified: 2014-05-14 13:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (7.46 KB, patch)
2014-05-14 11:44 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC. (8.38 KB, patch)
2014-05-14 12:36 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-05-14 09:50:05 PDT 
Implement NSSharingServiceDelegate method "transitionImageForShareItem"

<rdar://problem/16878020>
Comment 1 Brady Eidson 2014-05-14 11:44:46 PDT 
Created attachment 231461 [details]
Patch v1
Comment 2 Tim Horton 2014-05-14 11:52:29 PDT 
Comment on attachment 231461 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231461&action=review

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:443
> +    buffer->context()->translate(-FloatSize(rect.x(), rect.y()));

-toFloatSize(rect.location())

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:444
> +    frameView->paintContents(buffer->context(), IntRect(rect));

is this truncated FloatRect->IntRect right?
Comment 3 Brady Eidson 2014-05-14 12:36:50 PDT 
Created attachment 231462 [details]
Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC.
Comment 4 Brady Eidson 2014-05-14 13:12:52 PDT 
http://trac.webkit.org/changeset/168859