RESOLVED FIXED 132902
[EFL][WK2] Fix an unit test of ewk_context_url_scheme_register() 
https://bugs.webkit.org/show_bug.cgi?id=132902
Summary [EFL][WK2] Fix an unit test of ewk_context_url_scheme_register()
Gyuyoung Kim
Reported 2014-05-14 04:26:48 PDT
The unit test has been failed for a long time.
Attachments
WIP (2.27 KB, patch)
2014-05-14 04:29 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2014-05-14 18:49 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.52 KB, patch)
2014-05-14 21:28 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-05-14 04:29:46 PDT
Created attachment 231443 [details] WIP
Gyuyoung Kim
Comment 2 2014-05-14 18:49:55 PDT
Created attachment 231477 [details] Patch
Anders Carlsson
Comment 3 2014-05-14 21:24:32 PDT
Comment on attachment 231477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231477&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:128 > +#if ENABLE(CUSTOM_PROTOCOL) > ewk_context_url_scheme_register(ewk_view_context_get(webView()), "fooscheme", schemeRequestCallback, 0); > - ASSERT_TRUE(loadUrlSync("fooscheme:MyPath")); > - ASSERT_STREQ("Foo", ewk_view_title_get(webView())); > + ewk_view_url_set(webView(), "fooscheme:MyPath"); > + > + ASSERT_TRUE(waitUntilTrue(finishTest, testTimeoutSeconds)); > +#else > + ewk_context_url_scheme_register(ewk_view_context_get(webView()), "fooscheme", schemeRequestCallback, 0); > + ewk_view_url_set(webView(), "fooscheme:MyPath"); > + > + ASSERT_FALSE(waitUntilTrue(finishTest, testTimeoutSeconds)); > +#endif Does the test even need to run at all when custom protocols are disabled? I'd just put the entire test inside #if ENABLE(CUSTOM_PROTOCOL) and get rid of the #else block.
Gyuyoung Kim
Comment 4 2014-05-14 21:28:41 PDT
Created attachment 231489 [details] Patch for landing
Gyuyoung Kim
Comment 5 2014-05-14 21:29:44 PDT
(In reply to comment #3) > (From update of attachment 231477 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231477&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:128 > > +#if ENABLE(CUSTOM_PROTOCOL) > > ewk_context_url_scheme_register(ewk_view_context_get(webView()), "fooscheme", schemeRequestCallback, 0); > > - ASSERT_TRUE(loadUrlSync("fooscheme:MyPath")); > > - ASSERT_STREQ("Foo", ewk_view_title_get(webView())); > > + ewk_view_url_set(webView(), "fooscheme:MyPath"); > > + > > + ASSERT_TRUE(waitUntilTrue(finishTest, testTimeoutSeconds)); > > +#else > > + ewk_context_url_scheme_register(ewk_view_context_get(webView()), "fooscheme", schemeRequestCallback, 0); > > + ewk_view_url_set(webView(), "fooscheme:MyPath"); > > + > > + ASSERT_FALSE(waitUntilTrue(finishTest, testTimeoutSeconds)); > > +#endif > > Does the test even need to run at all when custom protocols are disabled? I'd just put the entire test inside #if ENABLE(CUSTOM_PROTOCOL) and get rid of the #else block. Removed #else block. Thanks.
WebKit Commit Bot
Comment 6 2014-05-14 22:07:58 PDT
Comment on attachment 231489 [details] Patch for landing Clearing flags on attachment: 231489 Committed r168892: <http://trac.webkit.org/changeset/168892>
WebKit Commit Bot
Comment 7 2014-05-14 22:08:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.