Bug 132901 - [getUserMedia] getUserMedia() errorCallback MUST be validated
Summary: [getUserMedia] getUserMedia() errorCallback MUST be validated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-14 03:56 PDT by Kiran
Modified: 2014-05-14 09:59 PDT (History)
9 users (show)

See Also:

Attachments
Validation missing for getUserMedia errorCallBack (5.08 KB, patch)
2014-05-14 04:12 PDT, Kiran 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kiran 2014-05-14 03:56:39 PDT 
Validation for getUserMedia() errorCallback is missing.
According to spec, successCallBack and errorCallBack are non-nullable and mandatory [1].
But code is validating successCallBack but missing to validate errorCallBack.

[1] http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-NavigatorUserMedia-getUserMedia-void-MediaStreamConstraints-constraints-NavigatorUserMediaSuccessCallback-successCallback-NavigatorUserMediaErrorCallback-errorCallback
Comment 1 Kiran 2014-05-14 04:12:48 PDT 
Created attachment 231442 [details]
Validation missing for getUserMedia errorCallBack

Please review the patch for validating getUserMedia errorCallback.
Comment 2 WebKit Commit Bot 2014-05-14 09:59:45 PDT 
Comment on attachment 231442 [details]
Validation missing for getUserMedia errorCallBack

Clearing flags on attachment: 231442

Committed r168842: <http://trac.webkit.org/changeset/168842>
Comment 3 WebKit Commit Bot 2014-05-14 09:59:49 PDT 
All reviewed patches have been landed.  Closing bug.