Bug 132900 - GIF animations don't restart after scrolling on iOS WebKit1
Summary: GIF animations don't restart after scrolling on iOS WebKit1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-14 02:28 PDT by Antti Koivisto
Modified: 2014-05-14 09:24 PDT (History)
0 users

See Also:

Attachments
patch (2.60 KB, patch)
2014-05-14 02:33 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-05-14 02:28:00 PDT 
a bug
Comment 1 Antti Koivisto 2014-05-14 02:33:59 PDT 
Created attachment 231438 [details]
patch
Comment 2 Andreas Kling 2014-05-14 02:37:18 PDT 
Comment on attachment 231438 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231438&action=review

OK

> Source/WebKit/mac/WebView/WebView.mm:1581
> +    FrameView* view = [self _mainCoreFrame]->view();

I think "FrameView *view" is the appropriate style here.
Comment 3 Antti Koivisto 2014-05-14 02:49:24 PDT 
http://trac.webkit.org/changeset/168830
Comment 4 Darin Adler 2014-05-14 09:24:24 PDT 
Comment on attachment 231438 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231438&action=review

>> Source/WebKit/mac/WebView/WebView.mm:1581
>> +    FrameView* view = [self _mainCoreFrame]->view();
> 
> I think "FrameView *view" is the appropriate style here.

No, the style is right. We do that different formatting thing with * only for Objective-C types, not for C++ types like FrameView.

We should probably change the rule though. The only place where we need the "X *" style is in public Objective-C headers. Inside the code it would be easier if we adopted a consistent rule.