Bug 132897 - Use INT_MAX instead of UINT_MAX to indicate end-of-segment
Summary: Use INT_MAX instead of UINT_MAX to indicate end-of-segment
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-13 20:50 PDT by Myles C. Maxfield
Modified: 2014-05-16 19:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2014-05-13 20:53 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Not for review (5.77 KB, patch)
2014-05-16 19:30 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-05-13 20:50:15 PDT 
Use INT_MAX instead of UINT_MAX to indicate end-of-segment
Comment 1 Myles C. Maxfield 2014-05-13 20:52:51 PDT 
<rdar://problem/16492909>
Comment 2 Myles C. Maxfield 2014-05-13 20:53:41 PDT 
Created attachment 231430 [details]
Patch
Comment 3 Geoffrey Garen 2014-05-13 22:50:23 PDT 
Comment on attachment 231430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231430&action=review

> Source/WebCore/ChangeLog:16
> +        No new tests.

Why not?
Comment 4 Anders Carlsson 2014-05-14 06:24:58 PDT 
I think this should use std::numeric_limits<int>::max() instead of INT_MAX.
Comment 5 Maciej Stachowiak 2014-05-15 17:42:12 PDT 
Comment on attachment 231430 [details]
Patch

I think it would be good to have a test that would have triggered the asserts or crashed. But also: I don't see any asserts in the patch. Is that a bug in the patch or the ChangeLog? r- for lack of test and for incorrect ChangeLog. Also please see andersca's comment.
Comment 6 Myles C. Maxfield 2014-05-16 19:30:48 PDT 
Created attachment 231617 [details]
Not for review