Bug 132893 – REGRESSION(WK2): Many pages have very wrong text size after rotating

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

Text autosizing seems to break most pages on rotation.

<rdar://problem/16806958>

[Enrica Casucci]

Created attachment 231423 [details]
Patch

[Benjamin Poulain]

Comment on attachment 231423 [details]
Patch

lgtm

[Darin Adler]

Comment on attachment 231423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231423&action=review

Sure would be nice to have some kind of bottleneck function rather than having a width check in three different places.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1910
> +    for (Frame* frame = &m_page->mainFrame(); frame; frame = frame->tree().traverseNext(&m_page->mainFrame())) {

This should just call traverseNext() with no arguments. There’s no reason to pass the main frame explicitly since there are no additional frames outside the main frame.

[Enrica Casucci]

Thanks for the feedback.
I've removed the parameter to traverseNext and changed resetTextAutosizingBeforeLayout to resetTextAutosizingBeforeLayoutIfNeeded which takes p;d and new size.
This way the width check is inside the new method.

[Enrica Casucci]

Committed revision 168848.