Bug 132891 - Web Inspector: Force developerExtrasEnabled when a remote client connects
Summary: Web Inspector: Force developerExtrasEnabled when a remote client connects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-13 16:30 PDT by Timothy Hatcher
Modified: 2014-05-13 18:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2014-05-13 16:34 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (3.13 KB, patch)
2014-05-13 16:49 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-05-13 16:30:41 PDT 
iOS does this currently in PageDebuggable. We need to do it on Mac too.

<rdar://problem/16332868>
Comment 1 Timothy Hatcher 2014-05-13 16:34:39 PDT 
Created attachment 231418 [details]
Patch
Comment 2 Joseph Pecoraro 2014-05-13 16:46:13 PDT 
Comment on attachment 231418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231418&action=review

r=me, Ultimately we should have our own way of forcing a setting on WebCore::Settings from inside of WebCore that don't adjust the exact same bit as WebKit APIs.

> Source/WebCore/page/PageDebuggable.cpp:103
> +    if (m_forcedDeveloperExtrasEnabled)
> +        m_page.settings().setDeveloperExtrasEnabled(false);

This should now flip m_forcedDeveloperExtrasEnabled back to false.
Comment 3 Timothy Hatcher 2014-05-13 16:49:14 PDT 
Created attachment 231422 [details]
Patch
Comment 4 WebKit Commit Bot 2014-05-13 17:22:09 PDT 
Comment on attachment 231422 [details]
Patch

Clearing flags on attachment: 231422

Committed r168764: <http://trac.webkit.org/changeset/168764>
Comment 5 WebKit Commit Bot 2014-05-13 17:22:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2014-05-13 18:01:42 PDT 
Build Fix: <http://trac.webkit.org/changeset/168767>