Bug 132889 - REGRESSION (topContentInset): Searching through Facebook Messenger's chat causes scrolling in News Feed
Summary: REGRESSION (topContentInset): Searching through Facebook Messenger's chat cau...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-13 15:19 PDT by Beth Dakin
Modified: 2014-05-13 17:14 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.56 KB, patch)
2014-05-13 15:33 PDT, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-05-13 15:19:09 PDT 
REGRESSION (topContentInset): Searching through Facebook Messenger's chat causes scrolling in News Feed

<rdar://problem/16715716>
Comment 1 Beth Dakin 2014-05-13 15:33:56 PDT 
Created attachment 231412 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-05-13 15:37:11 PDT 
Comment on attachment 231412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231412&action=review

> Source/WebCore/platform/ScrollView.cpp:430
> +    IntSize scrollOffset = this->scrollOffset();
> +    return IntSize(scrollOffset.width(), scrollOffset.height() - headerHeight());

return scrollOffset() - IntSize(0, headerHeight) ?

> Source/WebCore/platform/ScrollView.h:244
> +    // scrollOffset() anchors its (0,0) point at the top end of the scolling layer. When the Page

Seems odd for a comment in ScrollView.h to be talking about layers, since this is below the level of layer stuff. "at the top end" is odd too.
Comment 3 Beth Dakin 2014-05-13 17:14:58 PDT 
Thanks Simon! http://trac.webkit.org/changeset/168763