Bug 132886 – Crash in WebDocumentLoader::navigationID() running fast/dom/HTMLObjectElement/object-as-frame.html (after r168668?)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jon Honeycutt]

fast/dom/HTMLObjectElement/object-as-frame.html is flaky on on Mac WK2 debug, crashing with this backtrace:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit                  0x0000000106f169ec WebKit::WebDocumentLoader::navigationID() const + 12 (WebDocumentLoader.h:40)
1   com.apple.WebKit                  0x0000000106f114fb WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad(WebCore::ResourceError const&) + 203 (WebFrameLoaderClient.cpp:469)
2   com.apple.WebCore                 0x000000010961ca28 WebCore::FrameLoader::checkLoadCompleteForThisFrame() + 584 (FrameLoader.cpp:2210)
3   com.apple.WebCore                 0x00000001096157b4 WebCore::FrameLoader::checkLoadComplete() + 324 (FrameLoader.cpp:2442)
4   com.apple.WebCore                 0x000000010961eac8 WebCore::FrameLoader::receivedMainResourceError(WebCore::ResourceError const&) + 408 (FrameLoader.cpp:2731)
5   com.apple.WebCore                 0x000000010931edd4 WebCore::DocumentLoader::mainReceivedError(WebCore::ResourceError const&) + 324 (DocumentLoader.cpp:266)
6   com.apple.WebCore                 0x000000010931f82e WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource*) + 398 (DocumentLoader.cpp:383)
7   com.apple.WebCore                 0x0000000108f5f7ad WebCore::CachedResource::checkNotify() + 109 (CachedResource.cpp:332)
8   com.apple.WebCore                 0x0000000108f5f981 WebCore::CachedResource::error(WebCore::CachedResource::Status) + 145 (CachedResource.cpp:359)
9   com.apple.WebCore                 0x000000010a9fea99 WebCore::SubresourceLoader::didFail(WebCore::ResourceError const&) + 377 (SubresourceLoader.cpp:339)
10  com.apple.WebCore                 0x000000010a773525 WebCore::ResourceLoader::didFail(WebCore::ResourceHandle*, WebCore::ResourceError const&) + 101 (ResourceLoader.cpp:517)
11  com.apple.WebCore                 0x000000010ac6a9f3 -[WebCoreResourceHandleAsDelegate connection:didFailWithError:] + 259 (WebCoreResourceHandleAsDelegate.mm:310)
12  com.apple.Foundation              0x00007fff991b6d88 __65-[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:]_block_invoke_0 + 28



This may have started after r168668: <https://bugs.webkit.org/show_bug.cgi?id=132621>.

[Jon Honeycutt]

<http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdom%2FHTMLObjectElement%2Fobject-as-frame.html>

[Jon Honeycutt]

I can't reproduce this crash. I can't work on this in the short term because I'm headed out of town, so I'm preparing a roll out patch.

[Jon Honeycutt]

Created attachment 231424 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 231424 [details]
Patch

rs=me, but the patch doesn't apply.

[Jon Honeycutt]

Committed r168843: <http://trac.webkit.org/changeset/168843>

[Carlos Alberto Lopez Perez]

r168668 also caused crashes on the GTK port for the test fast/dom/HTMLObjectElement/object-as-frame.html