Bug 132883 – Update positioning/drawing of the image controls button

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Update positioning/drawing of the image controls button

<rdar://problem/16885077>

[Brady Eidson]

Created attachment 231404 [details]
Patch v1

[Tim Horton]

Comment on attachment 231404 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231404&action=review

> Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp:101
> +    button->setAttribute(HTMLNames::styleAttr, String::format("right: %ipx; top: %ipx", positionOffset.width(), positionOffset.height()));

Is this the normal way to set style attributes? I think you should be using setInlineStyleProperty for efficiency. See my use in PDFPluginTextAnnotation.

> Source/WebCore/html/shadow/mac/imageControlsMac.css:-32
> -    right: 18px; /* FIXME: Why is right: 0px off the right edge of the parent? */

we should keep a comment about this nonsense, because it's still wrong. just... above.

[Brady Eidson]

https://trac.webkit.org/changeset/168728

[Tim Horton]

(In reply to comment #2)
> (From update of attachment 231404 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231404&action=review
> 
> > Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp:101
> > +    button->setAttribute(HTMLNames::styleAttr, String::format("right: %ipx; top: %ipx", positionOffset.width(), positionOffset.height()));
> 
> Is this the normal way to set style attributes? I think you should be using setInlineStyleProperty for efficiency. See my use in PDFPluginTextAnnotation.
> 
> > Source/WebCore/html/shadow/mac/imageControlsMac.css:-32
> > -    right: 18px; /* FIXME: Why is right: 0px off the right edge of the parent? */
> 
> we should keep a comment about this nonsense, because it's still wrong. just... above.

I meant, to avoid String::formats :D

setInlineStyleProperty(CSSPropertyTop, positionOffset.height(), CSS_PX);

etc.

[Brady Eidson]

Followed up in https://trac.webkit.org/changeset/168742