Bug 132882 - JIT breakpoints should be more informative
Summary: JIT breakpoints should be more informative
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 132903
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-13 12:51 PDT by Filip Pizlo
Modified: 2014-05-14 04:42 PDT (History)
7 users (show)

See Also:


Attachments
the patch (44.59 KB, patch)
2014-05-13 12:53 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff
a version that builds (44.11 KB, patch)
2014-05-13 15:11 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
try again! (44.15 KB, patch)
2014-05-13 16:32 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-05-13 12:51:25 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2014-05-13 12:53:52 PDT
Created attachment 231402 [details]
the patch
Comment 2 Oliver Hunt 2014-05-13 12:57:56 PDT
Comment on attachment 231402 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231402&action=review

> Source/JavaScriptCore/assembler/MacroAssembler.h:200
> -
> +    

drop this :D
Comment 3 Filip Pizlo 2014-05-13 13:35:02 PDT
(In reply to comment #2)
> (From update of attachment 231402 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231402&action=review
> 
> > Source/JavaScriptCore/assembler/MacroAssembler.h:200
> > -
> > +    
> 
> drop this :D

Fixed, thanks!
Comment 4 Filip Pizlo 2014-05-13 15:11:34 PDT
Created attachment 231410 [details]
a version that builds
Comment 5 Filip Pizlo 2014-05-13 16:32:05 PDT
Created attachment 231417 [details]
try again!
Comment 6 Filip Pizlo 2014-05-13 20:58:01 PDT
Landed in http://trac.webkit.org/changeset/168776