RESOLVED FIXED 132878
Web Inspector: recording is overused as both noun and verb in TimelineManager
https://bugs.webkit.org/show_bug.cgi?id=132878
Summary Web Inspector: recording is overused as both noun and verb in TimelineManager
Brian Burg
Reported 2014-05-13 11:17:05 PDT
For now, I propose changing the verb to 'capturing', and renaming the TimelineManager getters to .activeRecording and .isCapturing()
Attachments
the patch (23.44 KB, patch)
2014-05-26 14:12 PDT, Brian Burg
no flags
Radar WebKit Bug Importer
Comment 1 2014-05-13 11:17:45 PDT
Timothy Hatcher
Comment 2 2014-05-13 13:07:46 PDT
Sounds fine to me.
Brian Burg
Comment 3 2014-05-26 14:12:24 PDT
Created attachment 232096 [details] the patch
Joseph Pecoraro
Comment 4 2014-06-09 10:31:30 PDT
Comment on attachment 232096 [details] the patch Sounds good! rs=me
WebKit Commit Bot
Comment 5 2014-06-10 11:47:35 PDT
Comment on attachment 232096 [details] the patch Clearing flags on attachment: 232096 Committed r169754: <http://trac.webkit.org/changeset/169754>
WebKit Commit Bot
Comment 6 2014-06-10 11:47:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.