Bug 132877 – platform/mac/plugins/testplugin-onnew-onpaint.html failing after r168668

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jon Honeycutt]

platform/mac/plugins/testplugin-onnew-onpaint.html is failing after r168668, which made plug-in loading asynchronous.

[Jon Honeycutt]

Created attachment 231395 [details]
Patch

[Brent Fulgham]

Comment on attachment 231395 [details]
Patch

r=me

[Alexey Proskuryakov]

Comment on attachment 231395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231395&action=review

> LayoutTests/ChangeLog:9
> +        Make the test wait until plug-ins have loaded before finishing.

Is onload expected to fire after plug-ins load? An honest question, I don't know if this test change is required for correctness, or if it is papering over a bug.

[Alexey Proskuryakov]

I didn't mean to override the r+, but I think that this question is valid nonetheless.

[Jon Honeycutt]

(In reply to comment #3)
> (From update of attachment 231395 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231395&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        Make the test wait until plug-ins have loaded before finishing.
> 
> Is onload expected to fire after plug-ins load? An honest question, I don't know if this test change is required for correctness, or if it is papering over a bug.

No, onload should be firing after plug-ins load. This is covered by <rdar://problem/16858476>. However, all tests expecting synchronous plug-in loading should've been updated as part of r168668. This is just bringing this test in line with the others.

[Jon Honeycutt]

Landed in <http://trac.webkit.org/changeset/168743>.