Bug 132859 - [CSS Regions] Assertion failure in some cases with inline blocks
Summary: [CSS Regions] Assertion failure in some cases with inline blocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2014-05-13 02:19 PDT by Andrei Bucur
Modified: 2014-05-13 23:34 PDT (History)
5 users (show)

See Also:

Attachments
Repro (1012 bytes, text/html)
2014-05-13 02:20 PDT, Andrei Bucur 		no flags Details
Patch (16.21 KB, patch)
2014-05-13 06:54 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (16.30 KB, patch)
2014-05-13 07:01 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch with feedback (16.28 KB, patch)
2014-05-13 07:26 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2014-05-13 02:19:43 PDT 
See the attached repro.

If a line is pulled in a new region, the blocks contained by it don't clear the RenderBoxRegionInfo from the old region.
Comment 1 Andrei Bucur 2014-05-13 02:20:54 PDT 
Created attachment 231365 [details]
Repro
Comment 2 Andrei Bucur 2014-05-13 06:54:36 PDT 
Created attachment 231374 [details]
Patch
Comment 3 Andrei Bucur 2014-05-13 07:01:07 PDT 
Created attachment 231376 [details]
Patch
Comment 4 Radu Stavila 2014-05-13 07:04:18 PDT 
Comment on attachment 231376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231376&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3877
> +bool RenderBlock::hasRegionRangeInFlowThread() const

Shouldn't this method be in RenderBox?
Comment 5 Andrei Bucur 2014-05-13 07:26:32 PDT 
Created attachment 231379 [details]
Patch with feedback
Comment 6 Andrei Bucur 2014-05-13 07:27:00 PDT 
D(In reply to comment #4)
> (From update of attachment 231376 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231376&action=review
> 
> > Source/WebCore/rendering/RenderBlock.cpp:3877
> > +bool RenderBlock::hasRegionRangeInFlowThread() const
> 
> Shouldn't this method be in RenderBox?

Done.
Comment 7 Mihnea Ovidenie 2014-05-13 07:52:33 PDT 
Comment on attachment 231379 [details]
Patch with feedback

r=me
Comment 8 WebKit Commit Bot 2014-05-13 23:34:21 PDT 
Comment on attachment 231379 [details]
Patch with feedback

Clearing flags on attachment: 231379

Committed r168791: <http://trac.webkit.org/changeset/168791>
Comment 9 WebKit Commit Bot 2014-05-13 23:34:25 PDT 
All reviewed patches have been landed.  Closing bug.