Bug 132854 – Remove check-webkit-style warnings in JavascriptCore/dfg

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tanay]

Remove warnings of type :
*The parameter name x adds no information, so it should be removed.

[Tanay]

Created attachment 231440 [details]
Patch

[Darin Adler]

Comment on attachment 231440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231440&action=review

Most of the changes look like small improvements, but some of them make things a little worse and should not be done.

> Source/JavaScriptCore/dfg/DFGCapabilities.h:50
> -inline CapabilityLevel capabilityLevel(OpcodeID opcodeID, CodeBlock* codeBlock, Instruction* pc);
> +inline CapabilityLevel capabilityLevel(OpcodeID, CodeBlock*, Instruction*);

I am not sure that removing the name “pc” makes the code more clear. I would probably leave it in.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1974
> -    void addBranch(const MacroAssembler::JumpList& jump, BasicBlock* destination);
> +    void addBranch(const MacroAssembler::JumpList&, BasicBlock*);

Removing the name “destination” makes this less clear.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:2243
> +    void speculateString(Edge, GPRReg);
> +    void speculateStringIdentAndLoadStorage(Edge, GPRReg, GPRReg);
> +    void speculateStringIdent(Edge, GPRReg);

Removing the names “cell”, “string”, and “storage” here makes this less clear. Those names aren’t redundant.

[Tanay]

(In reply to comment #2)
> (From update of attachment 231440 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231440&action=review
> 
> Most of the changes look like small improvements, but some of them make things a little worse and should not be done.
> 
> > Source/JavaScriptCore/dfg/DFGCapabilities.h:50
> > -inline CapabilityLevel capabilityLevel(OpcodeID opcodeID, CodeBlock* codeBlock, Instruction* pc);
> > +inline CapabilityLevel capabilityLevel(OpcodeID, CodeBlock*, Instruction*);
> 
> I am not sure that removing the name “pc” makes the code more clear. I would probably leave it in.
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1974
> > -    void addBranch(const MacroAssembler::JumpList& jump, BasicBlock* destination);
> > +    void addBranch(const MacroAssembler::JumpList&, BasicBlock*);
> 
> Removing the name “destination” makes this less clear.
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:2243
> > +    void speculateString(Edge, GPRReg);
> > +    void speculateStringIdentAndLoadStorage(Edge, GPRReg, GPRReg);
> > +    void speculateStringIdent(Edge, GPRReg);
> 
> Removing the names “cell”, “string”, and “storage” here makes this less clear. Those names aren’t redundant.

Ok, I will omit the changes you mentioned above and submit a patch.

[Tanay]

Created attachment 231497 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 231497 [details]
Patch

Clearing flags on attachment: 231497

Committed r169040: <http://trac.webkit.org/changeset/169040>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.