RESOLVED FIXED132833
Limit number of active graphics contexts per web process 
https://bugs.webkit.org/show_bug.cgi?id=132833
Summary Limit number of active graphics contexts per web process
Roger Fong
Reported 2014-05-12 13:16:30 PDT
We will limit number of active WebGL contexts per webprocess to 16. This should essentially be thought of as your machine running out of resources after 16 contexts are active.
Attachments
patch (4.21 KB, patch)
2014-05-12 15:12 PDT, Roger Fong 		no flags
DetailsFormatted DiffDiff
better patch (4.54 KB, patch)
2014-05-12 17:15 PDT, Roger Fong 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-05-12 13:23:14 PDT
<rdar://problem/16888465>
Roger Fong
Comment 2 2014-05-12 13:26:51 PDT
Actually this: <rdar://problem/16888459>
Roger Fong
Comment 3 2014-05-12 15:12:43 PDT
Created attachment 231330 [details] patch
Roger Fong
Comment 4 2014-05-12 17:15:36 PDT
Created attachment 231349 [details] better patch
Dean Jackson
Comment 5 2014-05-12 17:25:01 PDT
Comment on attachment 231349 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=231349&action=review > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:118 > + return 0; return nullptr; > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:123 > + return 0; return nullptr; > LayoutTests/webgl/many-contexts.html:13 > + for (var i = 0; i < size; i++) { > + canvii[i] = document.createElement("canvas"); > + canvii[i].width = 1; > + canvii[i].height = 1; > + var context = canvii[i].getContext("webgl", null); > + } Weird indentation. Also, I wonder if we should check that context == null at 1000 (assuming that we might raise the number above 16, but never to 1000).
Roger Fong
Comment 6 2014-05-12 18:11:55 PDT
Committed http://trac.webkit.org/changeset/168666 with fixes.
Note You need to log in before you can comment on or make changes to this bug.