Cygwin's Python 2.7 requires very specific path handling to work around some nuances in the way the Python distribution is installed under Cygwin (see Bug 132023 for details, as well as <http://trac.webkit.org/changeset/167685>). This patch corrects another place in our build system where we are not explicit about where to find Python under Cygwin.
<rdar://problem/16885618>
<rdar://problem/16885619>
Created attachment 231305 [details] Patch
Comment on attachment 231305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231305&action=review r=me > Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:79 > +my $python = ($^O =~ /cygwin/) ? "/usr/bin/python" : "python"; Nit: Would be nice to have a more readable for of "$^O". Since off-hand I have no idea what it means.
Comment on attachment 231305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231305&action=review >> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:79 >> +my $python = ($^O =~ /cygwin/) ? "/usr/bin/python" : "python"; > > Nit: Would be nice to have a more readable for of "$^O". Since off-hand I have no idea what it means. s/for of/version of/
Created attachment 231306 [details] Patch
Comment on attachment 231306 [details] Patch Much nicer! Thanks. r=me
Comment on attachment 231306 [details] Patch Clearing flags on attachment: 231306 Committed r168648: <http://trac.webkit.org/changeset/168648>
All reviewed patches have been landed. Closing bug.