Bug 132812 – Make a few icon database improvements

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Adler]

Make a few icon database improvements

[Darin Adler]

Created attachment 231276 [details]
Patch

[WebKit Commit Bot]

Attachment 231276 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

This takes care of a mistake I noticed after reviewing bug 132805 and quite a bit of other tidying I noticed while fixing that mistake.

[Darin Adler]

These are mostly minor refactoring and removing unused things.

[Darin Adler]

Brady said he’d likely review this later today.

[Brady Eidson]

Comment on attachment 231276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231276&action=review

> ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Stylebot is wrong about this, and the bugzilla has been filed.  But...

> ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Missing space before {  [whitespace/braces] [5]
Stylebot is right about this.  For c++ lambas we put a space between the close paren and the open bracket.

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:311
> +    return API::Data::createWithoutCopying(reinterpret_cast<const unsigned char*>(sharedBuffer->data()), sharedBuffer->size(),

I didn't know about this - brilliant.

[Darin Adler]

Committed r168680: <http://trac.webkit.org/changeset/168680>