Bug 132812 - Make a few icon database improvements
Summary: Make a few icon database improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-12 00:42 PDT by Darin Adler
Modified: 2014-05-13 07:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (26.89 KB, patch)
2014-05-12 00:52 PDT, Darin Adler 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-05-12 00:42:01 PDT 
Make a few icon database improvements
Comment 1 Darin Adler 2014-05-12 00:52:30 PDT 
Created attachment 231276 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-12 00:54:04 PDT 
Attachment 231276 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-05-12 00:54:12 PDT 
This takes care of a mistake I noticed after reviewing bug 132805 and quite a bit of other tidying I noticed while fixing that mistake.
Comment 4 Darin Adler 2014-05-12 10:11:15 PDT 
These are mostly minor refactoring and removing unused things.
Comment 5 Darin Adler 2014-05-12 10:38:06 PDT 
Brady said he’d likely review this later today.
Comment 6 Brady Eidson 2014-05-12 11:05:54 PDT 
Comment on attachment 231276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231276&action=review

> ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Stylebot is wrong about this, and the bugzilla has been filed.  But...

> ERROR: Source/WebKit2/UIProcess/WebIconDatabase.cpp:312:  Missing space before {  [whitespace/braces] [5]
Stylebot is right about this.  For c++ lambas we put a space between the close paren and the open bracket.

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:311
> +    return API::Data::createWithoutCopying(reinterpret_cast<const unsigned char*>(sharedBuffer->data()), sharedBuffer->size(),

I didn't know about this - brilliant.
Comment 7 Darin Adler 2014-05-13 07:45:16 PDT 
Committed r168680: <http://trac.webkit.org/changeset/168680>