Bug 132801 - REGRESSION (r168119): Album flipping animation doesn’t work
Summary: REGRESSION (r168119): Album flipping animation doesn’t work
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://scarey.org/albums/lp
Keywords: InRadar
Depends on:
Reported: 2014-05-10 23:54 PDT by Jon Lee
Modified: 2014-08-06 16:06 PDT (History)
7 users (show)

See Also:

Patch (7.65 KB, patch)
2014-08-06 15:54 PDT, Simon Fraser (smfr)
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2014-05-10 23:54:08 PDT
Go to: http://scarey.org/albums/lp and try to click on the album art to make it flip.

The back cover flashes, then disappears. The front cover remains visible, rendered backward.
Comment 1 Radar WebKit Bug Importer 2014-05-10 23:54:19 PDT
Comment 2 Simon Fraser (smfr) 2014-05-11 11:37:11 PDT
When applying the transform to flip, we're not doing layout so not updating the "m_hasTransformedAncestor" flags.
Comment 3 Simon Fraser (smfr) 2014-05-11 12:21:57 PDT
Forcing layout when style changes between having a transform and not having one is not enough to fix this; we evaluate compositing at the start of the transition, when we've set the identity matrix on an ancestor (which will then animate to a 3D matrix).
Comment 4 Simon Fraser (smfr) 2014-05-11 13:47:00 PDT
Also have to deal with animations that go from 2D -> 3D matrix.
Comment 5 Simon Fraser (smfr) 2014-08-06 15:54:29 PDT
Created attachment 236148 [details]
Comment 6 WebKit Commit Bot 2014-08-06 15:57:54 PDT
Attachment 236148 [details] did not pass style-queue:

ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:2395:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Simon Fraser (smfr) 2014-08-06 16:06:24 PDT