Bug 132799 - Clean up MainThreadTask
Summary: Clean up MainThreadTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 132800
  Show dependency tree / graph
 
Reported: 2014-05-10 23:19 PDT by Zan Dobersek
Modified: 2014-05-12 00:05 PDT (History)
1 user (show)

See Also:

Attachments
Patch (26.38 KB, patch)
2014-05-10 23:25 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-05-10 23:19:45 PDT 
Clean up MainThreadTask
Comment 1 Zan Dobersek 2014-05-10 23:25:17 PDT 
Created attachment 231252 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-10 23:26:46 PDT 
Attachment 231252 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/MainThreadTask.h:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/MainThreadTask.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-05-11 11:14:03 PDT 
Comment on attachment 231252 [details]
Patch

A fine refinement. But I suggest we do the cross-thread copying explicitly and use plain old lambdas rather than having this MainThreadTask class at all.
Comment 4 Zan Dobersek 2014-05-12 00:05:27 PDT 
Comment on attachment 231252 [details]
Patch

Clearing flags on attachment: 231252

Committed r168611: <http://trac.webkit.org/changeset/168611>
Comment 5 Zan Dobersek 2014-05-12 00:05:34 PDT 
All reviewed patches have been landed.  Closing bug.