Bug 132760 - Web Inspector: ConsoleGroup-related code mixes model and view functionality
Summary: Web Inspector: ConsoleGroup-related code mixes model and view functionality
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-09 17:05 PDT by Brian Burg
Modified: 2016-12-13 15:37 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-05-09 17:05:16 PDT 
This makes it hard to programmatically clear messages for a specific console group, say from CTRL+K shortcut, if that shortcut is handled outside of the view. Also, there are a bunch of weird parts of the code where we clone DOM elements to get around the fact that the data could be used by several views.

I would propose putting the console group trees and each groups' associated messages in LogManager.
Comment 1 Radar WebKit Bug Importer 2014-05-09 17:06:11 PDT 
<rdar://problem/16873871>
Comment 2 Timothy Hatcher 2014-05-09 17:06:46 PDT 
Sounds good.
Comment 3 Radar WebKit Bug Importer 2014-05-09 17:07:02 PDT 
<rdar://problem/16873886>