Bug 132754 – Web Inspector: empty timeline should not use previous timeline's zoom interval

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

As is, I feel this is really really confusing.

We could save timeline zoom intervals the same way we save other view state for back-forward navigations, but for unrelated page executions I don't see the use case.

[Radar WebKit Bug Importer]

<rdar://problem/16872739>

[Timothy Hatcher]

"unrelated page executions" is the key phase here. I find keeping the zoom level is useful for reload cases. Restoring a sane default for new / unrelated loads sounds fine.

[Brian Burg]

This should be per-TimelineRecording, with a sane default.

[Brian Burg]

Created attachment 236325 [details]
Patch

[Timothy Hatcher]

Comment on attachment 236325 [details]
Patch

I think we should attempt to keep the state when reloading at minimum. If you are trying to see somthing happen on load it is annoying to keep fiddling with the zoom and selection. Maybe we need a hybrid approach here? First timeline uses saved settings, subsequent timelines get a sane default at the beginning of time? Maybe secondsPerPixel can always persist?

[Brian Burg]

If the recording is explicitly started via the button, then any subsequent reload navigations do not appear at the start of the recording. So I think you are suggesting that we reuse the same zoom setting for auto-capturing sessions on the same page as the previous auto-capturing session.

[Timothy Hatcher]

Correct. Only the auto-recorded timeline.

[Timothy Hatcher]

Comment on attachment 236325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236325&action=review

Lets fix this up and make reload reuse the previous settings. Otherwise I am on board with doing this.

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:71
> +    this.selectionDuration = 5;

5 seconds seems short now. 10 or 15?

[Matt Baker]

Created attachment 253082 [details]
[Patch] Proposed Fix

[Matt Baker]

Wrong patch, disregard.

[Matt Baker]

Created attachment 253169 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 253169 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253169&action=review

r=me

> Source/WebInspectorUI/ChangeLog:23
> +        Increase default selection time to 15 seconds.

I'm surprised by this, but I'll trust your judgement!

[Simon Fraser (smfr)]

Yay!

[WebKit Commit Bot]

Comment on attachment 253169 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 253169

Committed r184429: <http://trac.webkit.org/changeset/184429>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.