Bug 132746 - {TelephoneNumber, Selection}OverlayControllerMac don't handle tiled drawing properly
Summary: {TelephoneNumber, Selection}OverlayControllerMac don't handle tiled drawing p...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2014-05-09 11:53 PDT by Brent Fulgham
Modified: 2014-05-09 13:58 PDT (History)
4 users (show)

See Also:

Patch (2.70 KB, patch)
2014-05-09 12:00 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (4.35 KB, patch)
2014-05-09 13:53 PDT, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-05-09 11:53:54 PDT
The drawing method for TelephoneNumberOverlayControllerMac draws more often than it needs to. It also improperly restricts the region that the UI uses to layout the data detector interface, resulting in strange drawing effects if a phone number spans two (or more) tiles.
Comment 1 Brent Fulgham 2014-05-09 11:54:14 PDT
Comment 2 Brent Fulgham 2014-05-09 12:00:51 PDT
Created attachment 231175 [details]
Comment 3 Simon Fraser (smfr) 2014-05-09 12:03:35 PDT
Comment on attachment 231175 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=231175&action=review

> Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:102
> +        // Don't give the tile rect to the highlight drawing function. It will try to be smart and place the data detector arrow on
> +        // the left side of the highlight if we happen to cross a tile boundary. Instead, allow it to draw over the whole frame bounds,
> +        // and allow the context clipping to limit the drawing to the region we want to see.

I don't think this comment is necessary. It explains why you fix this bug, but I don't think it adds value for the future.
Comment 4 Brent Fulgham 2014-05-09 12:16:41 PDT
Comment on attachment 231175 [details]

I don't think the gtk-wk2 build failure is due to this change.
Comment 5 Brent Fulgham 2014-05-09 13:53:26 PDT
Created attachment 231184 [details]
Comment 6 Brent Fulgham 2014-05-09 13:58:27 PDT
Committed r168551: <http://trac.webkit.org/changeset/168551>