WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132743
Rename WebKit2.framework to WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=132743
Summary
Rename WebKit2.framework to WebKit.framework
Anders Carlsson
Reported
2014-05-09 09:39:56 PDT
Rename WebKit2.framework to WebKit.framework
Attachments
Patch
(275.93 KB, patch)
2014-05-09 10:03 PDT
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-05-09 10:03:43 PDT
Created
attachment 231160
[details]
Patch
WebKit Commit Bot
Comment 2
2014-05-09 10:06:47 PDT
Attachment 231160
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WebKit2_C.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/C/WebKit2_C.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/Cocoa/WebKit.m:31: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 243 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3
2014-05-09 11:15:49 PDT
Comment on
attachment 231160
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231160&action=review
> Source/WebKit2/Configurations/WebKit2.xcconfig:27 > +INFOPLIST_FILE = mac/WebKit2.plist;
Let’s call this Info-WebKit2.plist
> Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:45 > + CFBundleRef webKit2Bundle = CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit"));
Let’s rename this to webKitBundle.
> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:92 > + NSBundle *webKit2Bundle = [NSBundle bundleWithIdentifier:@"com.apple.WebKit"];
webKitBundle
> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:8005 > + WebKit2.xcodeproj,
Strange
> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:9277 > + VERSION_INFO_PREFIX = "";
Can we get rid of this?
> ChangeLog:13 > + * WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: > + Ditto.
There’s another shared scheme to update here.
Anders Carlsson
Comment 4
2014-05-09 11:40:47 PDT
Committed
r168541
: <
http://trac.webkit.org/changeset/168541
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug