WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132733
[WK2] Make generate-forwarding-headers.pl work after WebKit2.framework -> WebKit.framework rename
https://bugs.webkit.org/show_bug.cgi?id=132733
Summary
[WK2] Make generate-forwarding-headers.pl work after WebKit2.framework -> Web...
Csaba Osztrogonác
Reported
2014-05-09 03:14:35 PDT
Here is the announcement about it: [webkit-dev] PSA: WebKit2.framework -> WebKit.framework
https://lists.webkit.org/pipermail/webkit-dev/2014-May/026552.html
Now the generate-forwarding-headers.pl does these steps: - searches all framework style includes in this format: <JavaScriptCore/*.h>, <WebCore/*.h> and <WebKit2/*.h> - find the proper header in JavaScriptCore, WebCore and WebKit2 - generate forwarding headers, for example: <somewhere-in-WebKitBuild>/WebKit2/foo.h: #include <WebKit2/real-path-of-the-header/.../.../foo.h> After the change mentioned the announcemnet, generate-forwarding-headers.pl should - search <WebKit/*.h> styled includes in WebKit2 - find the proper header in WebKit2, not in WebKit as the framework name - generate forwarding headers, for example: <somewhere-in-WebKitBuild>/WebKit/foo.h: #include <WebKit2/real-path-of-the-header/.../.../foo.h> It means WebKit2 needs to be handled differently from this change, because the directory name will be different from the framework name.
Attachments
Proposed patch
(4.10 KB, patch)
2014-05-09 05:02 PDT
,
Martin Hodovan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Hodovan
Comment 1
2014-05-09 05:02:33 PDT
Created
attachment 231143
[details]
Proposed patch
Csaba Osztrogonác
Comment 2
2014-05-09 05:12:15 PDT
Comment on
attachment 231143
[details]
Proposed patch LGTM, r=me. Thanks for the quick fix.
WebKit Commit Bot
Comment 3
2014-05-09 05:49:59 PDT
Comment on
attachment 231143
[details]
Proposed patch Clearing flags on attachment: 231143 Committed
r168525
: <
http://trac.webkit.org/changeset/168525
>
WebKit Commit Bot
Comment 4
2014-05-09 05:50:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug