Bug 132733 - [WK2] Make generate-forwarding-headers.pl work after WebKit2.framework -> WebKit.framework rename
Summary: [WK2] Make generate-forwarding-headers.pl work after WebKit2.framework -> Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Martin Hodovan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-09 03:14 PDT by Csaba Osztrogonác
Modified: 2014-05-09 05:50 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (4.10 KB, patch)
2014-05-09 05:02 PDT, Martin Hodovan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-05-09 03:14:35 PDT 
Here is the announcement about it:
[webkit-dev] PSA: WebKit2.framework -> WebKit.framework
https://lists.webkit.org/pipermail/webkit-dev/2014-May/026552.html

Now the generate-forwarding-headers.pl does these steps:
- searches all framework style includes in this format:
  <JavaScriptCore/*.h>, <WebCore/*.h> and <WebKit2/*.h>
- find the proper header in JavaScriptCore, WebCore and WebKit2
- generate forwarding headers, for example:
  <somewhere-in-WebKitBuild>/WebKit2/foo.h:
  #include <WebKit2/real-path-of-the-header/.../.../foo.h>

After the change mentioned the announcemnet, generate-forwarding-headers.pl should 
- search <WebKit/*.h> styled includes in WebKit2 
- find the proper header in WebKit2, not in WebKit as the framework name
- generate forwarding headers, for example:
  <somewhere-in-WebKitBuild>/WebKit/foo.h:
  #include <WebKit2/real-path-of-the-header/.../.../foo.h>

It means WebKit2 needs to be handled differently from this change,
because the directory name will be different from the framework name.
Comment 1 Martin Hodovan 2014-05-09 05:02:33 PDT 
Created attachment 231143 [details]
Proposed patch
Comment 2 Csaba Osztrogonác 2014-05-09 05:12:15 PDT 
Comment on attachment 231143 [details]
Proposed patch

LGTM, r=me. Thanks for the quick fix.
Comment 3 WebKit Commit Bot 2014-05-09 05:49:59 PDT 
Comment on attachment 231143 [details]
Proposed patch

Clearing flags on attachment: 231143

Committed r168525: <http://trac.webkit.org/changeset/168525>
Comment 4 WebKit Commit Bot 2014-05-09 05:50:01 PDT 
All reviewed patches have been landed.  Closing bug.