[iOS][WK2] Set up the resize events
Created attachment 231131 [details]
Comment on attachment 231131 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=231131&action=review
This is so tricky that it really demands test coverage; we need to figure out how to test this in an automated way. I’m really concerned that we will break this in the future.
Should run the sort-export-file script. I’m pretty sure that this will sort lower in the file, because it’s a literal ASCII sort, so 9F will come after 10.
> + , m_isChangingObscuredInsetsInteractively(isChangingObscuredInsetsInteractively)
We want to initialize this to false above in the default constructor too.
> + frameView.setCustomSizeForResizeEvent(roundedIntSize(unobscuredContentRectSizeInContentCoordinates));
I worry about the use of rounded in all the various cases like this, but I suppose it’s not new. Is rounding correct as opposed to ceiling or floor?
Created attachment 231189 [details]
Comment on attachment 231189 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=231189&action=review
> + Wire the UI Process updates to frameview to send the resize events appropriately.
Can you explain the "now gets two chances" here in the change log?
> + bool m_useCustomSizeForResizeEvent;
You forgot to initialize this in the constructor.
Committed r168556: <http://trac.webkit.org/changeset/168556>