Bug 132718 – com.apple.iphonesimulator.startSession needs to pass “runtimeIdentifier”

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Farler]

The simulator runtime may not be able to find a runtime via sdkRoot; its first choice is a runtime identifier keyed off of the SDK version. We should pass this along in the com.apple.iphonesimulator.startSession in old-run-webkit-tests. To allow this, IPhoneSimulatorNotification.pm needs to take all the keys that we give it. It’s currently filtering out a hard-coded list of keys — it won’t hurt to have more items in an NSNotification userInfo dictionary.

[David Farler]

Created attachment 231118 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 231118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231118&action=review

r=me

> Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:204
> -    my $userInfo = NSMutableDictionary->dictionaryWithCapacity_(4);
> -    for my $property (qw(applicationArguments applicationEnvironment applicationIdentifier applicationPath deviceFamily deviceInfo productType sessionOwner sessionUUID sdkRoot version waitForDebugger)) {
> -        if (exists $dict->{$property}) {
> -            my $key = NSString->stringWithCString_($property);
> -            my $value = $dict->{$property};
> -            $userInfo->setObject_forKey_($value, $key);
> -        }
> +    my $userInfo = NSMutableDictionary->dictionaryWithCapacity_(scalar(keys($dict)) + 1);
> +    foreach my $key (keys($dict)) {
> +        $userInfo->setObject_forKey_($dict->{$key}, $key);

Nice!

[WebKit Commit Bot]

Comment on attachment 231118 [details]
Patch

Clearing flags on attachment: 231118

Committed r168547: <http://trac.webkit.org/changeset/168547>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.