In Safari, we automatically archive document bundles when submitted via forms. Let's do the same for File API. We can pre-compute file type and name, but if a script asks for size, we'll need to synchronously archive at this point. If a script does not, we can do this lazily when uploading (e.g. the script could build a blob with file parts, and use Blob or FormData forms of XMLHttpRequest.send()). <rdar://problem/13397892>
Created attachment 231113 [details] proposed patch
Attachment 231113 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/mac/BlobDataFileReferenceMac.mm:63: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/network/mac/BlobDataFileReferenceMac.mm:69: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 231113 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231113&action=review > Source/WebCore/FileMac.mm:1 > +/* I don't think you meant to put this file here.
Comment on attachment 231113 [details] proposed patch Attachment 231113 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5682755736174592 New failing tests: http/tests/misc/empty-file-formdata.html
Created attachment 231123 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 231113 [details] proposed patch Attachment 231113 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4803655119142912 New failing tests: svg/text/non-bmp-positioning-lists.svg http/tests/misc/empty-file-formdata.html
Created attachment 231125 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 231127 [details] patch for landing
Comment on attachment 231127 [details] patch for landing Clearing flags on attachment: 231127 Committed r168518: <http://trac.webkit.org/changeset/168518>
All reviewed patches have been landed. Closing bug.
Forgot to land the tests. Landed them in <http://trac.webkit.org/r168908>.