Bug 132712 - [EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an ASSERT.
Summary: [EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an A...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-08 16:19 PDT by Jer Noble
Modified: 2014-05-09 08:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2014-05-08 16:23 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-05-08 16:19:38 PDT 
[EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an ASSERT.
Comment 1 Jer Noble 2014-05-08 16:23:15 PDT 
Created attachment 231108 [details]
Patch
Comment 2 Eric Carlson 2014-05-08 18:16:48 PDT 
Comment on attachment 231108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44
> +    session->suspendIfNeeded();

Why not do this in the constructor?
Comment 3 Jer Noble 2014-05-09 08:21:50 PDT 
(In reply to comment #2)
> (From update of attachment 231108 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review
> 
> > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44
> > +    session->suspendIfNeeded();
> 
> Why not do this in the constructor?

We could, but it's generally a bad idea to call virtual functions in the constructor.
Comment 4 WebKit Commit Bot 2014-05-09 08:54:34 PDT 
Comment on attachment 231108 [details]
Patch

Clearing flags on attachment: 231108

Committed r168533: <http://trac.webkit.org/changeset/168533>
Comment 5 WebKit Commit Bot 2014-05-09 08:54:37 PDT 
All reviewed patches have been landed.  Closing bug.