RESOLVED FIXED 132712
[EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an ASSERT. 
https://bugs.webkit.org/show_bug.cgi?id=132712
Summary [EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an A...
Jer Noble
Reported 2014-05-08 16:19:38 PDT
[EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an ASSERT.
Attachments
Patch (1.73 KB, patch)
2014-05-08 16:23 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-05-08 16:23:15 PDT
Created attachment 231108 [details] Patch
Eric Carlson
Comment 2 2014-05-08 18:16:48 PDT
Comment on attachment 231108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44 > + session->suspendIfNeeded(); Why not do this in the constructor?
Jer Noble
Comment 3 2014-05-09 08:21:50 PDT
(In reply to comment #2) > (From update of attachment 231108 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review > > > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44 > > + session->suspendIfNeeded(); > > Why not do this in the constructor? We could, but it's generally a bad idea to call virtual functions in the constructor.
WebKit Commit Bot
Comment 4 2014-05-09 08:54:34 PDT
Comment on attachment 231108 [details] Patch Clearing flags on attachment: 231108 Committed r168533: <http://trac.webkit.org/changeset/168533>
WebKit Commit Bot
Comment 5 2014-05-09 08:54:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.