Bug 132706 – REGRESSION (r168053): Phone number detection boxes are wrong when scrolled

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Beth Dakin]

REGRESSION (r168053): Phone number detection boxes are wrong when scrolled

<rdar://problem/16787957>

[Beth Dakin]

Created attachment 231101 [details]
Patch

[Beth Dakin]

Thanks Tim! http://trac.webkit.org/changeset/168499

[Darin Adler]

Comment on attachment 231101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231101&action=review

> Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:66
> +    size_t size = textQuads.size();
> +    for (size_t i = 0; i < size; ++i)
> +        boundingRect.unite(textQuads[i].boundingBox());

Should use a modern for loop:

    for (auto& quad : textQuads)
        boundingRect.unit(quad.boundingBox());