Bug 132698 - [MSE][Mac] Move AVStreamDataParser off-main-thread.
Summary: [MSE][Mac] Move AVStreamDataParser off-main-thread.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 132710
  Show dependency tree / graph
 
Reported: 2014-05-08 12:17 PDT by Jer Noble
Modified: 2014-05-08 17:22 PDT (History)
13 users (show)

See Also:

Attachments
Patch (18.11 KB, patch)
2014-05-08 12:25 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing. (20.47 KB, patch)
2014-05-08 15:15 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-05-08 12:17:14 PDT 
[MSE][Mac] Move AVStreamDataParser off-main-thread.
Comment 1 Jer Noble 2014-05-08 12:25:07 PDT 
Created attachment 231089 [details]
Patch
Comment 2 Eric Carlson 2014-05-08 12:38:46 PDT 
Comment on attachment 231089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231089&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:496
> +    RefPtr<SourceBufferPrivateAVFObjC> strongThis(this);

Nit: why do you initialize this RefPtr with constructor syntax and the previous ones with assignment?
Comment 3 Jer Noble 2014-05-08 15:15:38 PDT 
Created attachment 231103 [details]
Patch for landing.
Comment 4 Jer Noble 2014-05-08 15:30:01 PDT 
(In reply to comment #2)
> (From update of attachment 231089 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231089&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:496
> > +    RefPtr<SourceBufferPrivateAVFObjC> strongThis(this);
> 
> Nit: why do you initialize this RefPtr with constructor syntax and the previous ones with assignment?

No good reason.  Fixed that, and updated the patch so as to not break GTK.
Comment 5 Jer Noble 2014-05-08 17:22:02 PDT 
Committed r168508: <http://trac.webkit.org/changeset/168508>