Bug 132696 - Cue display events may not be registered during page load
Summary: Cue display events may not be registered during page load
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-08 11:51 PDT by Brent Fulgham
Modified: 2014-05-08 12:04 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.59 KB, patch)
2014-05-08 12:00 PDT, Brent Fulgham
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-05-08 11:51:21 PDT
Because of the way 'cuechange' events are processed in the new Media Script controls code, it's possible to have a page where text tracks are added to the DOM before the handlers for add-and-remove tracks are ready. When this happens, the "cue change" events that WebKit relies on to generate the tracks for display do not get added, and captions do not get displayed.

This patch changes WebKit so that we handle cue display events in the back end, which bypasses this potential start-up issue and ensure proper caption display.
Comment 1 Brent Fulgham 2014-05-08 11:55:38 PDT
<rdar://problem/16652874>
Comment 2 Brent Fulgham 2014-05-08 12:00:22 PDT
Created attachment 231086 [details]
Patch
Comment 3 Brent Fulgham 2014-05-08 12:04:09 PDT
Committed r168479: <http://trac.webkit.org/changeset/168479>