RESOLVED FIXED 132694
Wrap a new class definition with __has_include() 
https://bugs.webkit.org/show_bug.cgi?id=132694
Summary Wrap a new class definition with __has_include()
Brady Eidson
Reported 2014-05-08 11:26:28 PDT
Wrap a new class definition with __has_include(), as the include might be on some systems. <rdar://problem/16852395>
Attachments
Patch v1 (1.65 KB, patch)
2014-05-08 11:29 PDT, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-05-08 11:29:02 PDT
Created attachment 231082 [details] Patch v1
Tim Horton
Comment 2 2014-05-08 11:30:08 PDT
Comment on attachment 231082 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231082&action=review > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:58 > // FIXME: We should properly disable code that interacts with NSItemProvider/NSSharingServicePicker in 32-bit. we may have done this?
Brady Eidson
Comment 3 2014-05-08 11:34:26 PDT
(In reply to comment #2) > (From update of attachment 231082 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231082&action=review > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:58 > > // FIXME: We should properly disable code that interacts with NSItemProvider/NSSharingServicePicker in 32-bit. > > we may have done this? We disabled some code. I haven't looked to make sure we did it "properly"
Brady Eidson
Comment 4 2014-05-08 12:16:19 PDT
http://trac.webkit.org/changeset/168482
Note You need to log in before you can comment on or make changes to this bug.