RESOLVED FIXED 132685
REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
https://bugs.webkit.org/show_bug.cgi?id=132685
Summary REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same...
Carlos Garcia Campos
Reported 2014-05-08 09:11:40 PDT
We used to build all WebKit2 C API tests into a single binary TestWebKit2 to reduce the build time. We also adapted the run-gtk-tests script to run the tests individually to apply the timous for every test, so I think it's worth bringin back the single binary.
Attachments
Patch (6.00 KB, patch)
2014-05-09 05:08 PDT, Carlos Garcia Campos
mrobinson: review+
Martin Robinson
Comment 1 2014-05-08 12:11:01 PDT
It's kind of nice that we can share the build instructions with other ports, so we should weigh the options carefully.
Carlos Garcia Campos
Comment 2 2014-05-08 23:58:08 PDT
(In reply to comment #1) > It's kind of nice that we can share the build instructions with other ports, so we should weigh the options carefully. But we are building the WTF tests as a single binary, I don't understand why this inconsistency. I'm not sure what we are sharing for the WebKit2 test, because we have a list of binaries in our PlatformGTK file.
Carlos Garcia Campos
Comment 3 2014-05-09 05:08:04 PDT
Created attachment 231144 [details] Patch This would also fix bug #132684, since the single binary is TestWebKit2
Martin Robinson
Comment 4 2014-05-09 09:31:37 PDT
Comment on attachment 231144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231144&action=review > Tools/TestWebKitAPI/PlatformGTK.cmake:107 > +add_test(TestWebKit2 ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2) > +set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60) > +set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2) We don't actually need these lines since we don't use the CMake's 'make test.'
Carlos Garcia Campos
Comment 5 2014-05-09 23:40:06 PDT
(In reply to comment #4) > (From update of attachment 231144 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231144&action=review > > > Tools/TestWebKitAPI/PlatformGTK.cmake:107 > > +add_test(TestWebKit2 ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2) > > +set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60) > > +set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2) > > We don't actually need these lines since we don't use the CMake's 'make test.' I copy pasted like a monkey :-P I guess it doesn't hurt in any case and it's consistent with the other tests
Carlos Garcia Campos
Comment 6 2014-05-10 00:17:35 PDT
Note You need to log in before you can comment on or make changes to this bug.