We used to build all WebKit2 C API tests into a single binary TestWebKit2 to reduce the build time. We also adapted the run-gtk-tests script to run the tests individually to apply the timous for every test, so I think it's worth bringin back the single binary.
It's kind of nice that we can share the build instructions with other ports, so we should weigh the options carefully.
(In reply to comment #1) > It's kind of nice that we can share the build instructions with other ports, so we should weigh the options carefully. But we are building the WTF tests as a single binary, I don't understand why this inconsistency. I'm not sure what we are sharing for the WebKit2 test, because we have a list of binaries in our PlatformGTK file.
Created attachment 231144 [details] Patch This would also fix bug #132684, since the single binary is TestWebKit2
Comment on attachment 231144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231144&action=review > Tools/TestWebKitAPI/PlatformGTK.cmake:107 > +add_test(TestWebKit2 ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2) > +set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60) > +set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2) We don't actually need these lines since we don't use the CMake's 'make test.'
(In reply to comment #4) > (From update of attachment 231144 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231144&action=review > > > Tools/TestWebKitAPI/PlatformGTK.cmake:107 > > +add_test(TestWebKit2 ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2) > > +set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60) > > +set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2) > > We don't actually need these lines since we don't use the CMake's 'make test.' I copy pasted like a monkey :-P I guess it doesn't hurt in any case and it's consistent with the other tests
Committed r168574: <http://trac.webkit.org/changeset/168574>