Bug 132682 - [iOS WebKit2] Can't activate text fields on Facebook
Summary: [iOS WebKit2] Can't activate text fields on Facebook
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-08 07:55 PDT by Antti Koivisto
Modified: 2014-05-08 14:53 PDT (History)
2 users (show)

See Also:

Attachments
patch (8.79 KB, patch)
2014-05-08 08:14 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch 2 (6.93 KB, patch)
2014-05-08 09:10 PDT, Antti Koivisto 		enrica: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-05-08 07:55:25 PDT 
Content change observer fails to complete
Comment 1 Antti Koivisto 2014-05-08 07:55:58 PDT 
<rdar://problem/16315823>
Comment 2 Antti Koivisto 2014-05-08 08:14:57 PDT 
Created attachment 231067 [details]
patch
Comment 3 Antti Koivisto 2014-05-08 09:10:17 PDT 
Created attachment 231072 [details]
patch 2

The same patch without changing CheckForVisibilityChangeOnRecalcStyle to match the old behavior. This is not needed to fix Facebook and the new behavior is arguably more sensible than the old one.
Comment 4 Antti Koivisto 2014-05-08 09:11:03 PDT 
If it is needed it is better done separately.
Comment 5 Enrica Casucci 2014-05-08 09:23:10 PDT 
Comment on attachment 231072 [details]
patch 2

Looks good!
Comment 6 Antti Koivisto 2014-05-08 09:43:31 PDT 
https://trac.webkit.org/r168473
Comment 7 Benjamin Poulain 2014-05-08 14:53:42 PDT 
Comment on attachment 231072 [details]
patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=231072&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1199
> +    RefPtr<WebCore::Node> m_pendingSyntheticClickNode;
> +    WebCore::FloatPoint m_pendingSyntheticClickLocation;

You should put those next to m_potentialTapNode && m_potentialTapLocation