Bug 132676 - Remove CSS_STICKY_POSITION guards
Summary: Remove CSS_STICKY_POSITION guards
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-05-08 02:12 PDT by Tibor Mészáros
Modified: 2014-05-14 09:45 PDT (History)
4 users (show)

See Also:

Patch v1 (50.10 KB, patch)
2014-05-08 02:20 PDT, Tibor Mészáros
no flags Details | Formatted Diff | Diff
Patch v2 (50.03 KB, patch)
2014-05-08 04:20 PDT, Tibor Mészáros
ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
Patch v3 (50.02 KB, patch)
2014-05-13 04:49 PDT, Tibor Mészáros
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-05-08 02:12:51 PDT
It's a small feature that everyone has enabled, so we should get rid of the guard?

Reference to a discussion about it:
Comment 1 Tibor Mészáros 2014-05-08 02:20:07 PDT
Created attachment 231054 [details]
Patch v1

Comment 2 WebKit Commit Bot 2014-05-08 02:21:41 PDT
Attachment 231054 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 15 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tibor Mészáros 2014-05-08 04:20:07 PDT
Created attachment 231059 [details]
Patch v2

fixed style
Comment 4 Csaba Osztrogonác 2014-05-08 06:22:34 PDT
Comment on attachment 231059 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=231059&action=review

> ChangeLog:4
> +        Remove CSS_STICKY_POSITION
> +        https://bugs.webkit.org/show_bug.cgi?id=132676

This patch doens't remove CSS_STICKY_POSITION, but the guards only.
Comment 5 Tibor Mészáros 2014-05-13 04:49:02 PDT
Created attachment 231368 [details]
Patch v3

The bug/patch name has been changed.
Comment 6 WebKit Commit Bot 2014-05-14 09:45:25 PDT
Comment on attachment 231368 [details]
Patch v3

Clearing flags on attachment: 231368

Committed r168839: <http://trac.webkit.org/changeset/168839>
Comment 7 WebKit Commit Bot 2014-05-14 09:45:31 PDT
All reviewed patches have been landed.  Closing bug.