Bug 132661 - Use system defaults for hardware jpeg decoding
Summary: Use system defaults for hardware jpeg decoding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-07 13:50 PDT by Pratik Solanki
Modified: 2014-05-07 16:29 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.25 KB, patch)
2014-05-07 13:52 PDT, Pratik Solanki 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-05-07 13:50:35 PDT 
Use system defaults for hardware jpeg decoding
Comment 1 Pratik Solanki 2014-05-07 13:52:43 PDT 
Created attachment 231019 [details]
Patch
Comment 2 Pratik Solanki 2014-05-07 13:53:14 PDT 
<rdar://problem/11348201>
Comment 3 Tim Horton 2014-05-07 13:54:27 PDT 
Comment on attachment 231019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231019&action=review

> Source/WebKit/mac/WebView/WebViewPrivate.h:-468
> -+ (void)_setAcceleratedImageDecoding:(BOOL)enabled;
> -+ (BOOL)_acceleratedImageDecoding;

Please triple check that these aren't used anywhere.
Comment 4 Pratik Solanki 2014-05-07 16:28:14 PDT 
(In reply to comment #3)
> (From update of attachment 231019 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231019&action=review
> 
> > Source/WebKit/mac/WebView/WebViewPrivate.h:-468
> > -+ (void)_setAcceleratedImageDecoding:(BOOL)enabled;
> > -+ (BOOL)_acceleratedImageDecoding;
> 
> Please triple check that these aren't used anywhere.

Good catch. I did find one client. I am going to leave _setAcceleratedImageDecoding as an empty method.
Comment 5 Pratik Solanki 2014-05-07 16:29:47 PDT 
Committed r168452: <http://trac.webkit.org/changeset/168452>