WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132647
Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/
https://bugs.webkit.org/show_bug.cgi?id=132647
Summary
Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/
Sergio Villar Senin
Reported
2014-05-07 05:02:16 PDT
Summary says it all
Attachments
Patch
(108.36 KB, patch)
2014-05-07 07:48 PDT
,
Sergio Villar Senin
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1
2014-05-07 07:48:15 PDT
Created
attachment 230997
[details]
Patch
Darin Adler
Comment 2
2014-05-07 18:00:47 PDT
Comment on
attachment 230997
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=230997&action=review
Seems like there is an inefficient pattern here of all these sets, but thanks for modernizing the idiom at least.
> Source/WebCore/svg/SVGUseElement.cpp:60 > +#include <wtf/NeverDestroyed.h>
This should be up above with the #includes (at the bottom of them), not here down below the commented-out #defines.
Sergio Villar Senin
Comment 3
2014-05-08 03:59:55 PDT
Committed
r168469
: <
http://trac.webkit.org/changeset/168469
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug