Bug 132647 - Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/
Summary: Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks: 130185
  Show dependency tree / graph
 
Reported: 2014-05-07 05:02 PDT by Sergio Villar Senin
Modified: 2014-05-08 03:59 PDT (History)
12 users (show)

See Also:

Attachments
Patch (108.36 KB, patch)
2014-05-07 07:48 PDT, Sergio Villar Senin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2014-05-07 05:02:16 PDT 
Summary says it all
Comment 1 Sergio Villar Senin 2014-05-07 07:48:15 PDT 
Created attachment 230997 [details]
Patch
Comment 2 Darin Adler 2014-05-07 18:00:47 PDT 
Comment on attachment 230997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230997&action=review

Seems like there is an inefficient pattern here of all these sets, but thanks for modernizing the idiom at least.

> Source/WebCore/svg/SVGUseElement.cpp:60
> +#include <wtf/NeverDestroyed.h>

This should be up above with the #includes (at the bottom of them), not here down below the commented-out #defines.
Comment 3 Sergio Villar Senin 2014-05-08 03:59:55 PDT 
Committed r168469: <http://trac.webkit.org/changeset/168469>