Bug 132637 – [Mac, iOS] Add source application accounting to AVURLAsset.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac, iOS] Add source application accounting to AVURLAsset.

[Jer Noble]

Created attachment 231088 [details]
Patch

[Eric Carlson]

Comment on attachment 231088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review

> Source/WebCore/ChangeLog:8
> +        Property account for the application responisble for data loading by passing the source

Nit: Do you mean "Properly"?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154
> +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *)

Should you use SOFT_LINK_POINTER_OPTIONAL for older systems?

[Jer Noble]

(In reply to comment #2)
> (From update of attachment 231088 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Property account for the application responisble for data loading by passing the source
> 
> Nit: Do you mean "Properly"?

I do!

Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154
> > +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *)
> 
> Should you use SOFT_LINK_POINTER_OPTIONAL for older systems?

Good catch. I'll do this and check that it's non-null before adding it to the options dictionary.

I'll upload a new patch to address the other platform build errors.

[Jer Noble]

Created attachment 231111 [details]
Patch for landing.

[Jer Noble]

Committed r168512: <http://trac.webkit.org/changeset/168512>