Bug 132637 - [Mac, iOS] Add source application accounting to AVURLAsset.
Summary: [Mac, iOS] Add source application accounting to AVURLAsset.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-06 19:07 PDT by Jer Noble
Modified: 2014-05-08 18:07 PDT (History)
8 users (show)

See Also:

Attachments
Patch (14.88 KB, patch)
2014-05-08 12:06 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing. (14.62 KB, patch)
2014-05-08 16:40 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-05-06 19:07:59 PDT 
[Mac, iOS] Add source application accounting to AVURLAsset.
Comment 1 Jer Noble 2014-05-08 12:06:58 PDT 
Created attachment 231088 [details]
Patch
Comment 2 Eric Carlson 2014-05-08 12:24:24 PDT 
Comment on attachment 231088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review

> Source/WebCore/ChangeLog:8
> +        Property account for the application responisble for data loading by passing the source

Nit: Do you mean "Properly"?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154
> +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *)

Should you use SOFT_LINK_POINTER_OPTIONAL for older systems?
Comment 3 Jer Noble 2014-05-08 16:37:18 PDT 
(In reply to comment #2)
> (From update of attachment 231088 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Property account for the application responisble for data loading by passing the source
> 
> Nit: Do you mean "Properly"?

I do!

Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154
> > +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *)
> 
> Should you use SOFT_LINK_POINTER_OPTIONAL for older systems?

Good catch. I'll do this and check that it's non-null before adding it to the options dictionary.

I'll upload a new patch to address the other platform build errors.
Comment 4 Jer Noble 2014-05-08 16:40:11 PDT 
Created attachment 231111 [details]
Patch for landing.
Comment 5 Jer Noble 2014-05-08 18:07:26 PDT 
Committed r168512: <http://trac.webkit.org/changeset/168512>