132629 – Do the bmalloc.

Bug 132629 - Do the bmalloc.

Summary: Do the bmalloc.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Platform (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andreas Kling

URL:
Keywords:

Depends on:
Blocks:

Reported:	2014-05-06 15:19 PDT by Andreas Kling
Modified:	2015-01-10 11:54 PST (History)
CC List:	7 users (show)

See Also:

Attachments
Snack for EWS (431 bytes, patch) 2014-05-06 15:21 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
Snack Fighter II: World Warrior (1.92 KB, patch) 2014-05-06 15:55 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
Snackcraft III: The Frozen Throne (2.63 KB, patch) 2014-05-06 17:26 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
Patch (3.69 KB, patch) 2014-05-10 13:12 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (1.07 KB, patch) 2014-08-14 14:44 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (1002 bytes, patch) 2014-08-18 11:37 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (1003 bytes, patch) 2014-08-18 11:44 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (1.03 KB, patch) 2014-08-19 14:00 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (3.49 KB, patch) 2014-08-20 10:46 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (1.70 KB, patch) 2014-08-20 13:19 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (4.74 KB, patch) 2014-08-20 17:55 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (991 bytes, patch) 2014-09-03 14:26 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (990 bytes, patch) 2014-09-04 13:28 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (991 bytes, patch) 2014-09-10 13:53 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (1000 bytes, patch) 2014-09-10 15:45 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (1000 bytes, patch) 2014-09-11 14:08 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Patch (977 bytes, patch) 2014-09-24 11:50 PDT, Geoffrey Garen	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (16) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Kling 2014-05-06 15:19:26 PDT

Comment 1 Andreas Kling 2014-05-06 15:21:13 PDT

Created attachment 230938 [details]
Snack for EWS

Comment 2 Benjamin Poulain 2014-05-06 15:37:20 PDT

Wooot! :)

Comment 3 Andreas Kling 2014-05-06 15:55:42 PDT

Created attachment 230945 [details]
Snack Fighter II: World Warrior

Comment 4 Andreas Kling 2014-05-06 17:26:18 PDT

Created attachment 230958 [details]
Snackcraft III: The Frozen Throne

Comment 5 Geoffrey Garen 2014-05-10 13:12:15 PDT

Created attachment 231231 [details]
Patch

Comment 6 Geoffrey Garen 2014-05-10 13:13:57 PDT

Giving this another try, since I think the bots must be crazy.

Comment 7 Csaba Osztrogonác 2014-05-19 08:45:21 PDT

(In reply to comment #6)
> Giving this another try, since I think the bots must be crazy.

I this the bots aren't crazy, but this patch made SVG tests crash:
https://webkit-queues.appspot.com/patch/231231

Comment 8 Csaba Osztrogonác 2014-05-19 08:46:43 PDT

Comment on attachment 231231 [details]
Patch

r- not to force EWS bots run in an infinite loop.

Comment 9 Geoffrey Garen 2014-08-14 14:44:18 PDT

Created attachment 236622 [details]
Patch

Comment 10 Andreas Kling 2014-08-14 14:58:26 PDT

Comment on attachment 236622 [details]
Patch

If it fits, etc.

Comment 11 Geoffrey Garen 2014-08-14 19:26:05 PDT

Tests are still crashing on EWS.

Comment 12 Pratik Solanki 2014-08-14 19:31:02 PDT

Comment on attachment 236622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236622&action=review

> Source/WTF/wtf/FastMalloc.cpp:104
> +#if (PLATFORM(MAC) || PLATFORM(IOS)) && (CPU(X86_64) || CPU(ARM64))

PLATFORM(COCOA) !

Comment 13 Geoffrey Garen 2014-08-18 11:37:42 PDT

Created attachment 236770 [details]
Patch

Comment 14 Geoffrey Garen 2014-08-18 11:38:07 PDT

Not really for review. Trying to reproduce EWS failure.

Comment 15 Geoffrey Garen 2014-08-18 11:44:08 PDT

Created attachment 236771 [details]
Patch

Comment 16 Geoffrey Garen 2014-08-19 14:00:45 PDT

Created attachment 236823 [details]
Patch

Comment 17 Geoffrey Garen 2014-08-20 10:46:05 PDT

Created attachment 236879 [details]
Patch

Comment 18 Geoffrey Garen 2014-08-20 13:19:14 PDT

Created attachment 236893 [details]
Patch

Comment 19 Geoffrey Garen 2014-08-20 17:55:28 PDT

Created attachment 236905 [details]
Patch

Comment 20 Geoffrey Garen 2014-09-03 14:26:13 PDT

Created attachment 237582 [details]
Patch

Comment 21 Geoffrey Garen 2014-09-03 14:27:27 PDT

Perhaps, with the fix for bug 136469, this will pass EWS now.

Comment 22 Geoffrey Garen 2014-09-04 13:28:04 PDT

Created attachment 237644 [details]
Patch

Comment 23 Michael Saboff 2014-09-04 13:32:45 PDT

Comment on attachment 237644 [details]
Patch

r=me

Comment 24 Geoffrey Garen 2014-09-05 11:07:35 PDT

Committed r173313: <http://trac.webkit.org/changeset/173313>

Comment 25 Geoffrey Garen 2014-09-10 13:53:50 PDT

Reopening to attach new patch.

Comment 26 Geoffrey Garen 2014-09-10 13:53:53 PDT

Created attachment 237905 [details]
Patch

Comment 27 Geoffrey Garen 2014-09-10 15:45:57 PDT

Created attachment 237912 [details]
Patch

Comment 28 Geoffrey Garen 2014-09-11 14:08:54 PDT

Created attachment 237987 [details]
Patch

Comment 29 Geoffrey Garen 2014-09-11 14:45:56 PDT

Committed r173540: <http://trac.webkit.org/changeset/173540>

Comment 30 Geoffrey Garen 2014-09-24 11:49:13 PDT

Rolled out in <http://trac.webkit.org/changeset/r173565>.

Comment 31 Geoffrey Garen 2014-09-24 11:50:10 PDT

Created attachment 238603 [details]
Patch

Comment 32 Geoffrey Garen 2014-09-24 15:07:49 PDT

Committed r173935: <http://trac.webkit.org/changeset/173935>

Comment 33 Geoffrey Garen 2014-10-24 10:00:46 PDT

Results from perf bots:

OSMemoryTesting/Snap2FinishedLoadingPost:Allocations:Total: 0% (no regression)

PLT: 5%

DOM/GetElement: 42.84%
jslib-attr-jquery: 18.1%
dromaeo-object-string: 13.3%
dom-modify: 12.3%
cssquery-jquery: 5%
cssquery-prototype: 4.8%
cssquery-dojo: 3.8%
dromaeo-object-array: 3.4%
jslib-style-jquery: 3.2%
DYEB: 2.4%
Parser/HTML5-8266-FullRender: 4%
Parser/HTML5-8266-ParseOnly: 5.6%
css-parser-yui: 10.2%
Parser/html-parser: 6.5%
Parser/textarea-parsing: 11.22%
Layout/floats_100_100: 7.22%
Layout/floats_100_100_nested: 9.32%
Layout/floats_20_100: 11.42%
Layout/floats_20_100_nested: 13.86%
Layout/layers_overlap_2d: 6.69%
Layout/auto-grid-lots-of-data: 4.3%
Layout/chapter-reflow-once-random: 3.8%
Layout/fixed-grid-lots-of-data: 5.92%
Interactive/window-resize: 2%
Animation/balls:FrameRate: 4%
DOM/CloneNodes: 13.93%
DOM/DOMDivWalk: 10.7%
DOM/GetElement: 42.84%
DOM/ModifyAttribute: 8.7%

Comment 34 Andreas Kling 2014-10-24 11:00:53 PDT

obamanotbad.jpg

Comment 35 Geoffrey Garen 2014-10-24 11:25:32 PDT

MallocBench result vs TCMalloc:

geometric mean speedup: 2.11x faster
biggest speedup (list_allocate): 4.09x faster