Bug 132622 - AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
Summary: AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-06 13:50 PDT by chris fleizach
Modified: 2014-05-07 09:18 PDT (History)
12 users (show)

See Also:

Attachments
patch (26.10 KB, patch)
2014-05-06 13:52 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (26.09 KB, patch)
2014-05-06 13:56 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (25.82 KB, patch)
2014-05-06 14:58 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2014-05-06 13:50:52 PDT 
The AXSelectTextWithCriteria mechanism needs to support capitalize, lowercase and uppercase to be complete

<rdar://problem/16462451>
Comment 1 chris fleizach 2014-05-06 13:52:40 PDT 
Created attachment 230929 [details]
patch
Comment 2 WebKit Commit Bot 2014-05-06 13:55:34 PDT 
Attachment 230929 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderText.h:245:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 chris fleizach 2014-05-06 13:56:36 PDT 
Created attachment 230930 [details]
patch
Comment 4 Samuel White 2014-05-06 14:55:51 PDT 
Comment on attachment 230930 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230930&action=review

Looks good.

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:437
> +        return JSValueMakeBoolean(context, false);

Did this sneak in accidentally? I might be missing something, but I don't see an equality test that would need this.
Comment 5 chris fleizach 2014-05-06 14:58:30 PDT 
Created attachment 230935 [details]
patch
Comment 6 WebKit Commit Bot 2014-05-07 09:18:16 PDT 
Comment on attachment 230935 [details]
patch

Clearing flags on attachment: 230935

Committed r168427: <http://trac.webkit.org/changeset/168427>
Comment 7 WebKit Commit Bot 2014-05-07 09:18:21 PDT 
All reviewed patches have been landed.  Closing bug.