Bug 132617 - Eliminate BlobStorageData
Summary: Eliminate BlobStorageData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-06 10:47 PDT by Alexey Proskuryakov
Modified: 2014-05-06 15:11 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch (28.39 KB, patch)
2014-05-06 10:51 PDT, Alexey Proskuryakov 		andersca: review+
Details | Formatted Diff | Diff
patch for landing (28.39 KB, patch)
2014-05-06 11:59 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-05-06 10:47:19 PDT 
BlobStorageData is an entirely useless wrapper around BlobData that confuses ownership.
Comment 1 Alexey Proskuryakov 2014-05-06 10:51:00 PDT 
Created attachment 230919 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-05-06 10:52:41 PDT 
Attachment 230919 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55:  The parameter name "blobData" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-05-06 11:59:22 PDT 
Created attachment 230921 [details]
patch for landing
Comment 4 WebKit Commit Bot 2014-05-06 15:11:36 PDT 
Comment on attachment 230921 [details]
patch for landing

Clearing flags on attachment: 230921

Committed r168382: <http://trac.webkit.org/changeset/168382>
Comment 5 WebKit Commit Bot 2014-05-06 15:11:42 PDT 
All reviewed patches have been landed.  Closing bug.